Fix: Add fallback for clipboard.writeText #7314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy button near field name previously was using
navigator.clipboard.writeText
, but I just found out that the API is only available for secure context: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeTextSo if developers are working locally on insecure context, copy button will fail. I believe I was working with https when I was adding this feature back then, so I didn't really catch the bug.
So I'm sending a fix PR to add a fallback to insecure context or old browsers.
Related GitHub issue(s)
#7237
Testing instructions
Screenshots / screencast
Changelog text for these changes
Bug: Copy button now works correctly in secure context. #7237 (@heybran)
PR checklist