Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with archive by making certain reducers public. #192

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

mbrandonw
Copy link
Member

The archive of isowords was failing with "undefined symbols" errors, like this:

ld: warning: Could not find or use auto-linked framework 'CoreAudioTypes': framework 'CoreAudioTypes' not found
ld: Undefined symbols:
nominal type descriptor for GameCore.GameOverLogic, referenced from:
_symbolic _____y_____y_____y_____y_____y___________AEyAfG_AEyAfG_AEyAfG______yAfGG_____yAfG_____GG_____G_____G_____GSay_____GAIGG_____GG 8GameCore01_A6SoundsV 22ComposableArchitecture20_PresentationReducerV 10TcaHelpers06FilterG0V AD09_OnChangeG0V AD0G7BuilderO9_SequenceV AA0A0V5StateV AQ6ActionO AD6ReduceV AD5ScopeV AA23WordSubmitButtonFeatureV AA0A9OverLogicV AA09TurnBasedX0V AA15ActiveGamesTrayV 12SharedModels15IndexedCubeFaceV AQ11DestinationV in DemoFeature.o

It looks like there is a bug in the Swift compiler that is perhaps being too zealous in removing private types, and so we had to make some things public.

@mbrandonw mbrandonw merged commit e385f3f into main Nov 16, 2023
2 checks passed
@mbrandonw mbrandonw deleted the fix-archive-with-public branch November 16, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants