Support typed throws #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
commented
Dec 8, 2024
| do { | ||
| _ = try res.get() | ||
| } catch { | ||
| XCTAssertEqual(error, SomeError()) |
There was a problem hiding this comment.
Without the change in the Result extension, this fails to compile with
.../Tests/ConcurrencyExtrasTests/ResultTests.swift:45:24 Cannot convert value of type 'any Error' to expected argument type 'ResultTests.SomeError'
finestructure
commented
Dec 8, 2024
|
|
||
| func testTypedThrows() async throws { | ||
| do { | ||
| let res = await Result { () async throws(SomeError) -> Int in try await g(0) } |
There was a problem hiding this comment.
Unfortunately, this explicit type-pinning of the closure (() async throws(SomeError) -> Int in) is load bearing. Without it, you still get a Result<Int, any Error> back. But at least this way the conversion can be expressed and res is of type Result<Int, SomeError>.
stephencelis
reviewed
Dec 9, 2024
Will do! |
finestructure
force-pushed
the
support-typed-throws
branch
from
17dc7a7 to
a30dcd5
Compare
|
Just checking in case you didn't see the additional commits I pushed - were you happy with those changes? Is there anything I should be updating? |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've started adopting typed throws in a couple of areas and I noticed that my
Resultextension to handleasyncclosures was clashing with the one in this package. The difference is subtle but I think this is a more general way to do this extension.As the test shows, this allows you to convert an
async throws(SomeError)into aResult<T, SomeError>. Without this change, the resulting type isResult<T, any Error>instead.