Conversation
wash2
commented
Sep 2, 2026
wash2
commented
Contributor
- I have disclosed use of any AI generated code in my commit messages.
- If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
- In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
- I understand these changes in full and will be able to respond to review comments.
- My change is accurately described in the commit message.
- My contribution is tested and working as described.
- I have read the Developer Certificate of Origin and certify my contribution under its conditions.
wash2
force-pushed
the
directional-nav
branch
from
September 2, 2026 04:26
c1a252f to
c3ced76
Compare
wash2
force-pushed
the
directional-nav
branch
6 times, most recently
from
September 11, 2026 15:52
da62ea7 to
9b212f9
Compare
wash2
marked this pull request as ready for review
September 11, 2026 15:52
mmstick
previously approved these changes
Sep 11, 2026
Contributor
Author
|
@pop-os/ux Actually, before I merge this, what do you think of autofocusing the first widget of a surface after it receives keyboard focus, if it does not already have a focused widget? Or would it be better to just restrict further keyboard navigation to the focused window, to avoid the focus indicator appearing? |
wash2
force-pushed
the
directional-nav
branch
from
September 14, 2026 22:01
9b212f9 to
e970856
Compare
mmstick
force-pushed
the
master
branch
2 times, most recently
from
September 15, 2026 12:44
8c7f938 to
d77e99f
Compare
wash2
force-pushed
the
directional-nav
branch
from
September 21, 2026 18:01
3b29e1c to
09bf531
Compare
more improvements need to be made to the menu to handle keyboard focus. Libcosmic should also probably redirect focus automatically to a focused window's widget if it does not have focus.
if a widget already has focus in the window, it will not be overriden
wash2
force-pushed
the
directional-nav
branch
from
September 23, 2026 16:04
09bf531 to
4938ce4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.