Conversation
The menu width is computed from selection paragraphs shaped with the regular font, but the selected option is drawn in semibold, which is wider. With no remaining slack, the selection check then overlaps the selected option's text. Measure the selected option again with the semibold font and take the max, in the overlay menu, the popup menu widget, and the popup positioner size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menu width is computed from selection paragraphs shaped with the regular font, but the selected option is drawn in semibold, which is wider. With no remaining slack, the selection check then overlaps the selected option's text. Measure the selected option again with the semibold font and take the max, in the overlay menu, the popup menu widget, and the popup positioner size.