Skip to content

fix(dropdown): measure selected option with semibold for menu width - #1452

Closed
s4mu3lbk wants to merge 1 commit into
pop-os:masterfrom
s4mu3lbk:fix/dropdown-menu-selected-width
Closed

s4mu3lbk wants to merge 1 commit into
pop-os:masterfrom
s4mu3lbk:fix/dropdown-menu-selected-width

Conversation

@s4mu3lbk

Copy link
Copy Markdown

The menu width is computed from selection paragraphs shaped with the regular font, but the selected option is drawn in semibold, which is wider. With no remaining slack, the selection check then overlaps the selected option's text. Measure the selected option again with the semibold font and take the max, in the overlay menu, the popup menu widget, and the popup positioner size.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

The menu width is computed from selection paragraphs shaped with the
regular font, but the selected option is drawn in semibold, which is
wider. With no remaining slack, the selection check then overlaps the
selected option's text. Measure the selected option again with the
semibold font and take the max, in the overlay menu, the popup menu
widget, and the popup positioner size.
@s4mu3lbk s4mu3lbk closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant