Repository navigation
Support Panel and hvPlot widgets - #253
Merged
Merged
Conversation
cpsievert
marked this pull request as ready for review
October 16, 2026 18:51
cpsievert
force-pushed
the
bokeh-extensions
branch
from
October 16, 2026 21:26
06d92e4 to
15ee301
Compare
cpsievert
changed the base branch from
main
to
feat/widget-lifetimes-03-browser
October 16, 2026 21:26
This was referenced Oct 16, 2026
cpsievert
force-pushed
the
bokeh-extensions
branch
from
October 16, 2026 21:58
3ac9698 to
4ce2636
Compare
cpsievert
changed the title
cpsievert
changed the base branch from
feat/widget-lifetimes-03-browser
to
feat/bokeh-extension-assets
October 16, 2026 21:58
This was referenced Oct 16, 2026
cpsievert
added this pull request to stack #265
October 19, 2026 23:33
cpsievert
force-pushed
the
bokeh-extensions
branch
from
October 19, 2026 23:37
4f27ef9 to
e93fb78
Compare
cpsievert
removed this pull request from stack #265
October 19, 2026 23:38
cpsievert
added this pull request to stack #266
October 19, 2026 23:41
Resolve conflicts between the _bokeh.py consolidation/head_content refactor and Panel support: - Panel's bundling path moves into _bokeh.py's bokeh_extension_urls() (now returns module info alongside js/css urls). - ES module assets no longer ride the dependency channel via MessageDependency's shinywidgets_module_exports dict. Instead, bokeh_extension_assets() returns them as plain data, _shinywidgets forwards them on the comm-open message, and the client import()s them (assigning default exports to globals) before model construction. This keeps imports awaited without a custom HTMLDependency subclass. - guard_widget_close() moves to _bokeh.py with the other bokeh-specific widget logic.
Closed
cpsievert
added a commit
that referenced
this pull request
Oct 20, 2026
Main's #253 added holoviews/hvPlot support via panel (render_hvplot). This merge keeps that panel-based implementation (hvplot already hard-depends on panel, and neither path preserves DynamicMap streams), and renames render_hvplot -> render_holoviews for discoverability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panel widgets and layouts, plus HoloViews/hvPlot objects, can render directly in Shiny with
@render_panel,@render_hvplot, or@render_widget. Core and Express apps load the required Bokeh and extension assets automatically through #255 and #256.Closes #82 and #87. Stacked on #256 (which stacks on #255).
Panel creates the Bokeh root through
pn.panel(...).get_root(). Its model stylesheets use the locally served Panel distribution, including later theme changes and styles inside shadow DOM. Panel-specific bundling also supplies ES modules and required exports for components such as Perspective. Roots are released when the owning widget closes or construction fails, while live owners retain them. Because jupyter_bokeh'sBokehModel.close()is not idempotent (a second call raisesKeyError, and__del__closes as well), Bokeh widgets get a close-once guard in this PR.This approach overlaps #250: it preserves the
render_hvplotAPI and uses Panel for HoloViews coercion. #250 remains open for that review decision.Validation:
make checkpasses (144 unit tests); the full Chromium suite passes (50 tests). Covers Tabulator data/sorting/rerenders with the Holoviz CDN blocked, Perspective rendering/data, hvPlot, later assets, Core/Express, mounted apps, and Panel root lifetimes. Served JavaScript rebuilt from source.Panel widget values are not exposed as Shiny inputs. ReactiveESM components have not been validated.