refactor: Fix lighthouse accessibility issue in footer links #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
Dec 4, 2024
Comment on lines
+15
to
+18
| /** | ||
| * Ideally kept sync'd with the markdown links: | ||
| * https://github.com/preactjs/preact-www/blob/f68e65aadbd19b042921cc175aa256f3aa248768/src/style/markdown.css#L18 | ||
| */ |
There was a problem hiding this comment.
As this comment would suggest, our new footer link styles should match the markdown links but we're relying on copy/paste for the moment. It's only a few lines and I don't imagine it'll change often.
JoviDeCroock
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can see this from local lighthouse runs or pagespeed insights.
While the message seems to suggest a contrast issue, this isn't actually the case -- our contrast ratios are 6.53:1 & 6.01:1 w/ light & dark preferences respectively, both hitting the WCAG AA standards. In fact, changing this to #fff on #000 still does nothing to dismiss the message. The actual issue, which I found unclear at least, is that links aren't meant to rely on color alone and so we need text decoration here. Reasonable enough.