[CARE-1802] Refactor - Extensions model #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1himself
force-pushed
the
refactor/care-1802-extensions-model
branch
2 times, most recently
from
6e296de to
e71b889
Compare
…hmentExtension` Additionally, keep the event tracking outside of it -- in the `getEnabledExtensions()` wiring function. Also, there it doesn't seem to have any sense in having `attachment-edit-clicked` event, thus I've dropped it.
Additionally, event tracking callbacks are passed from outside, to reduce coupling of the extension to the editor wiring logic.
Also, introduce additional tracked events: - `gallery-edited` - `gallery-shuffled` Additionally, gallery event tracking calls are now passed from outside to reduce code coupling.
For consistency with other extensions
To stop using `insertUploadedFile`
To avoid circular dependency
…xtensions - One for images and one for file attachments - Also, the decision about enabling specific file type pasting handler is now outsourced to the external code. It enables files pasting when attachments extension is enabled. Same for images.
To reduce code coupling to the `EditorEvents` module
Not using the deprecated LoaderExtension
This completely drops ImageCandidate elements from the data model
It's superseded by the Placeholders feature
… data files & items
…eExtendEditor()`
…nuExtension` � Conflicts: � packages/slate-editor/src/modules/editor/Editor.tsx � packages/slate-editor/src/modules/editor/Extensions.tsx
…icient UI component Related to 8d2a5e3 � Conflicts: � packages/slate-editor/src/extensions/snippet/SnippetsExtension.tsx � packages/slate-editor/src/modules/editor/Extensions.tsx
� Conflicts: � packages/slate-editor/src/modules/editor/Editor.tsx
…ionsEditor definition
…sionsEditor definition
…verrides to the ExtensionsEditor definition
… ExtensionsEditor definition
…nsionsEditor definition
… hook Without relying on `withOverrides()` � Conflicts: � packages/slate-editor/src/extensions/paste-slate-content/lib/withSlatePasting.ts � packages/slate-editor/src/modules/editor/Extensions.tsx
…an Extension � Conflicts: � packages/slate-editor/src/modules/editor/createEditor.ts � packages/slate-editor/src/modules/editor/plugins/index.ts � packages/slate-editor/src/modules/editor/plugins/withDeserializeHtml/withDeserializeHtml.ts
…extension hook Instead of relying on the hard-to-maintain `withOverrides` extension feature � Conflicts: � packages/slate-editor/src/extensions/loader/index.ts � packages/slate-editor/src/extensions/loader/transforms/index.ts � packages/slate-editor/src/extensions/loader/transforms/insertUploadingFile.ts � packages/slate-editor/src/extensions/paste-files/PasteFilesExtension.ts � packages/slate-editor/src/extensions/paste-files/lib/index.ts � packages/slate-editor/src/extensions/paste-images/PasteImagesExtension.ts � packages/slate-editor/src/extensions/paste-images/lib/index.ts
…new `insertBreak` extension hooks
Consolidate file attachments management inside `FileAttachmentExtension` module � Conflicts: � packages/slate-editor/src/extensions/paste-files/lib/createDataTransferHandler.ts � packages/slate-editor/src/extensions/placeholders/PlaceholdersManager.ts � packages/slate-editor/src/extensions/placeholders/elements/AttachmentPlaceholderElement.tsx � packages/slate-editor/src/extensions/placeholders/index.ts � packages/slate-editor/src/modules/events/types.ts
…entData()` hook
e1himself
force-pushed
the
refactor/care-1802-extensions-model
branch
from
a6fa3f7 to
dfef2fa
Compare
|
Closed in favour of #504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.