-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5기 임수진] SprintBoot URL Shortener 구현 미션 제출합니다. #66
Open
suzzingV
wants to merge
17
commits into
prgrms-be-devcourse:suzzingV
Choose a base branch
from
suzzingV:main
base: suzzingV
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzzingV
requested review from
SeokRae,
zxcv9203,
JIN-076,
voidmelody,
happyjamy,
tidavid1 and
YongNyeo
December 16, 2023 10:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
👩💻 요구 사항과 구현 내용
short url을 생성하는 알고리즘
controller
domain
dto
exception
handler
repository
service
#utils
✅ PR 포인트 & 궁금한 점
유효성 검사를 service 로직에서 하는 것이 좋다고 해서 service에 @Valid 를 사용해 유효성 검사를 해봤는데, service에서 유효성 검사를 할 땐 이렇게 어노테이션을 사용하기보다 validator을 구현해 쓰는 것이 좋은지 궁금합니다.