[#145 ] 책장 좋아요 개수 추가 & 내가 좋아요한 책장 list 조회 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-Gaerval-Dadok-BE into feature/bookshelf_like
Jacoco Test Coverage Reports
|
|
repository test case 추가해서 BookshelfSupportImpl.java 커버리지 92%까지 올렸습니다~ |
tinajeong
approved these changes
May 3, 2023
| Long likeCount, Long userId, String username, | ||
| String userNickname, String userProfileImage, JobGroup jobGroup, JobGroup.JobName jobName, int order) { | ||
| Long likeCount, boolean isLiked, Long userId, String username, | ||
| String userNickname, String userProfileImage, JobGroup jobGroup, JobGroup.JobName jobName, Integer order) { |
There was a problem hiding this comment.
order를 boxing한 형태로 변경하신 것 좋네요! 현재는 원시타입인 isLiked도 통일하면 좋을것 같습니다.
| user.profileImage.as("userProfileImage"), | ||
| job.jobGroup, job.jobName, job.sortOrder | ||
| ) | ||
| public Optional<BookShelfDetailResponse> findByIdWithUserAndJob(Long ownerId, Long userId) { |
There was a problem hiding this comment.
메소드 이름이 findByIdWithUserAndJob인데, 실제로는 ownerId와 userId를 기반으로 여러 테이블에서 데이터를 가져오는 메소드로 보여집니다! 메소드 이름을 더 명확하게 지정하는 것이 좋을것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍀 목적
책장 list 응답에 좋아요 개수 추가
내가 좋아요한 책장 list api 추가
#145