Add NIFSGadgetTrait, implement Mova's NIFSGadget, adapt Nova NIFSGadget into NIFSGadgetTrait #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucube
force-pushed
the
nifs-gadget-trait
branch
2 times, most recently
from
91e81a1 to
4ce5100
Compare
arnaucube
changed the title
arnaucube
force-pushed
the
nifs-gadget-trait
branch
3 times, most recently
from
4116358 to
6431558
Compare
|
Just finished with #145 |
arnaucube
force-pushed
the
nifs-gadget-trait
branch
8 times, most recently
from
a38a01a to
27efd41
Compare
|
Updated the PR rebasing to latest |
Merged
CPerezz
approved these changes
Nov 11, 2024
…et into NIFSGadgetTrait * add new NIFSGadgetTrait * implement Mova's NIFSGadget * refactor Nova NIFSGadget to fit into the new NIFSGadgetTrait * abstract NIFSGadget related tests for all implementors of NIFSGadgetTrait to avoid duplicated code in the tests between the different Nova variants gadget tests * frontends/noir update mimc usage since it has been migrated from noir's std into it's own repo
arnaucube
force-pushed
the
nifs-gadget-trait
branch
from
27efd41 to
1eac1c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new NIFSGadgetTrait
refactor Nova's NIFSGadget to fit into the new NIFSGadgetTrait
implement Mova's NIFSGadget
abstract NIFSGadget related tests for all implementors of
NIFSGadgetTrait to avoid duplicated code in the tests between the
different Nova variants gadget tests
frontends/noir: update mimc usage since it has been migrated from noir's std into it's own repo.
maincommit) due 4 days ago Noir released a new version which moves the mimc lib from std to a separate repo)