Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl hash committed instance gadget (#17) #31

Merged
merged 1 commit into from
Oct 12, 2023
Merged

impl hash committed instance gadget (#17) #31

merged 1 commit into from
Oct 12, 2023

Conversation

arnaucube
Copy link
Collaborator

resolves #17

Implements natively and in-circuit the committed instances hashes which are used as:

$$\mathsf{u}_i.X \stackrel{?}{=} H(vk, i, z_0, z_i, \mathsf{U}_i)$$

$$\mathsf{U}_{i+1}.X \leftarrow H(vk, i+1, z_0, z _{i+1} , U _{i+1} )$$

taking as inputs $j, z_0, z_j, U_j$ for $j \in {i, i+1}$.

@arnaucube arnaucube force-pushed the feature/hash-committed-instance branch 2 times, most recently from af359de to 65602fb Compare October 9, 2023 10:29
@arnaucube arnaucube requested review from CPerezz and han0110 October 9, 2023 10:32
@arnaucube arnaucube changed the title impl hash_committed_instance gadget (#17) impl hash committed instance gadget (#17) Oct 9, 2023
@arnaucube arnaucube force-pushed the feature/hash-committed-instance branch from 65602fb to 57cad9f Compare October 9, 2023 10:34
han0110
han0110 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CPerezz
CPerezz approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

src/folding/nova/circuits.rs Outdated Show resolved Hide resolved
@arnaucube
impl hash committed instance gadget (#17)
042fce7 
together with the native impl compatible with the gadget one
@arnaucube arnaucube force-pushed the feature/hash-committed-instance branch from 57cad9f to 042fce7 Compare October 12, 2023 07:59
@arnaucube arnaucube added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 422db75 Oct 12, 2023
3 checks passed
@arnaucube arnaucube deleted the feature/hash-committed-instance branch November 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPerezz CPerezz CPerezz approved these changes

@han0110 han0110 han0110 approved these changes

Assignees
No one assigned
Labels
circuits Nova
Projects
None yet
Milestone
Minimal first flow (Nova in Ethereum)
Development

Successfully merging this pull request may close these issues.

Implement hash committed instance circuit
3 participants
@arnaucube @han0110 @CPerezz