Feature/f circuit multiple in outs #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucube
force-pushed
the
feature/f-circuit-multiple-in-outs
branch
from
06b7711 to
505f948
Compare
CPerezz
approved these changes
Nov 6, 2023
arnaucube
force-pushed
the
feature/f-circuit-multiple-in-outs
branch
from
505f948 to
fe0e80b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing the circuits from Ph(r)asedos/Grapevine project made me realize that
FCircuitshould allow to work with multiple inputs and outputs.Additionally this PR also modifies the
FCircuittrait to prepare it for the frontend trait, in order to generate the constraints while being inside theAugmentedFCircuitand being folded at each step (for example for the Circom frontend, which has different needs than the arkworks frontend).