Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sumcheck #40

Merged
merged 37 commits into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
8e3d35a
feat: init sumcheck.rs
dmpierre Nov 22, 2023
68c6a9c
chore: rename
dmpierre Nov 22, 2023
6a6b5d1
feat: update lib and add trait for transcript with vec storing challe…
dmpierre Nov 24, 2023
e62379e
bugfix: mut self ref of transcript
dmpierre Nov 24, 2023
717da1d
feat: tentative sum-check using poseidon
dmpierre Nov 24, 2023
25126e4
refactor: remove extension trait and use initial trait
dmpierre Nov 28, 2023
6d19ab6
refactor: stop using extension trait, use initial Transcript trait
dmpierre Nov 28, 2023
c64c030
feat: generic over CurveGroup sum-check verifier and algorithm
dmpierre Nov 28, 2023
313fa1b
feat: implement generic sum-check veriy
dmpierre Nov 28, 2023
35e6b1d
bugfix: cargo clippy --fix
dmpierre Nov 28, 2023
d9c9211
chore: cargo fmt
dmpierre Nov 28, 2023
e80bdbd
feat: (unstable) sum-check implementation
dmpierre Dec 1, 2023
a3182bb
feat: start benches
dmpierre Dec 1, 2023
0933937
chore: run clippy
dmpierre Dec 1, 2023
09c627e
chore: run cargo fmt
dmpierre Dec 1, 2023
09c7973
feat: add sum-check tests + benches
dmpierre Dec 5, 2023
e6a3fa9
chore: clippy + fmt
dmpierre Dec 5, 2023
62e89db
chore: remove unstable sumcheck
dmpierre Dec 6, 2023
93d5c23
chore: delete duplicated sum-check code
dmpierre Dec 6, 2023
b4c81b9
chore: remove deleted sum-check code from lib.rs imports
dmpierre Dec 6, 2023
703b2fb
feat: remove non generic traits, implement sum-check with generic tra…
dmpierre Dec 6, 2023
5b992eb
chore: remove non-generic struct
dmpierre Dec 6, 2023
1c8743d
chore: remove non generic verifier
dmpierre Dec 6, 2023
e6ef4f9
feat: make nifms generic over transcript and update to use poseidon t…
dmpierre Dec 6, 2023
6f953c1
chore: cargo fmt
dmpierre Dec 6, 2023
9ef8141
chore: remove tmp benches
dmpierre Dec 6, 2023
c183339
chore: update cargo.toml
dmpierre Dec 6, 2023
748be57
refactor: remove Generic suffix
dmpierre Dec 6, 2023
3b4e70b
feat: prover state generic over CurveGroup
dmpierre Dec 6, 2023
7ac2c75
chore: disable clippy type complexity warning
dmpierre Dec 6, 2023
812d710
refactor: remove Transcript type and espresso transcript dependency
dmpierre Dec 7, 2023
c403591
refactor: SumCheckProver generic over CurveGroup
dmpierre Dec 9, 2023
5c0ff25
chore: add line to eof for `Cargo.toml`
dmpierre Dec 14, 2023
978776a
bugfix: add error handling on sum-check prove and verify
dmpierre Dec 15, 2023
4fa551d
chore: clippy fix
dmpierre Dec 15, 2023
b12397d
chore: add line at eof
dmpierre Dec 15, 2023
59431ec
fix: use `map_err` and call `to_string()` on `PolyIOPErrors`
dmpierre Dec 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ color-eyre = "=0.6.2"
# tmp imports for espresso's sumcheck
ark-serialize = "^0.4.0"
espresso_subroutines = {git="https://github.com/EspressoSystems/hyperplonk", package="subroutines"}
espresso_transcript = {git="https://github.com/EspressoSystems/hyperplonk", package="transcript"}
arnaucube marked this conversation as resolved.
Show resolved Hide resolved

[dev-dependencies]
ark-pallas = {version="0.4.0", features=["r1cs"]}
Expand Down
1 change: 0 additions & 1 deletion src/utils/espresso/sum_check/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ pub trait SumCheckVerifier<C: CurveGroup> {
type VPAuxInfo;
type ProverMessage;
type Challenge;
type Transcript;
type SumCheckSubClaim;

/// Initialize the verifier's state.
Expand Down
2 changes: 0 additions & 2 deletions src/utils/espresso/sum_check/verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ use ark_ff::PrimeField;
use ark_std::{end_timer, start_timer};

use espresso_subroutines::poly_iop::prelude::PolyIOPErrors;
use espresso_transcript::IOPTranscript;

#[cfg(feature = "parallel")]
use rayon::iter::{IndexedParallelIterator, IntoParallelIterator, ParallelIterator};
Expand All @@ -28,7 +27,6 @@ impl<C: CurveGroup> SumCheckVerifier<C> for IOPVerifierState<C> {
type VPAuxInfo = VPAuxInfo<C::ScalarField>;
type ProverMessage = IOPProverMessage<C::ScalarField>;
type Challenge = C::ScalarField;
type Transcript = IOPTranscript<C::ScalarField>;
type SumCheckSubClaim = SumCheckSubClaim<C::ScalarField>;

/// Initialize the verifier's state.
Expand Down
Loading