Adapt Nova usage of commitment to the generic trait #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucube
force-pushed
the
feature/nova-generic-commitment
branch
from
9118cb3 to
57180c0
Compare
han0110
approved these changes
Jan 29, 2024
arnaucube
force-pushed
the
feature/nova-generic-commitment
branch
from
57180c0 to
9590ad3
Compare
CPerezz
approved these changes
Jan 30, 2024
| @@ -1 +1 @@ | |||
| 1.73.0 | |||
| 1.75.0 | |||
There was a problem hiding this comment.
I was keeping with the latest release, but if it makes sense to stick to a specific one I'm also happy.
Comment on lines
+229
to
+231
| CP1: CommitmentProver<C1>, | ||
| // enforce that the CP2 is Pedersen commitment, since we're at Ethereum's EVM decider | ||
| CP2: CommitmentProver<C2, Params = PedersenParams<C2>>, |
There was a problem hiding this comment.
This looks good for now. But we need to find a way to simplify trait bounds here.
dmpierre
pushed a commit
that referenced
this pull request
Feb 2, 2024
This was referenced May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.