Adding groth16, kzg10 and final decider verifiers in a dedicated workspace #69
Conversation
- update lib.rs's `FoldingScheme` trait interface - fit Nova+CycleFold into the `FoldingScheme` trait - refactor `src/nova/*`
Now we include an `assets` folder with a serialized proof & vk for tests
…or loop to account for whitespaces
…16 template with verifying key
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
this file does not exist in main branch https://github.com/privacy-scaling-explorations/folding-schemes/tree/main/src/folding/nova
| @@ -0,0 +1,686 @@ | |||
| /// This file implements the onchain (Ethereum's EVM) decider circuit. For non-ethereum use cases, | |||
There was a problem hiding this comment.
this file appears as 'new' when it should be as 'file renamed without changes' (since it exist in the main branch: https://github.com/privacy-scaling-explorations/folding-schemes/blob/main/src/folding/nova/decider_eth_circuit.rs )
Could it be that the PR branch is not getting all the changes from the main branch?
There was a problem hiding this comment.
Also for pedersen.rs. I've done in this branch an update getting the branch of the current PR and the last main version into folding-schemes subdir, if that is useful: main...feature/solidity-verifiers-from-last-main
There was a problem hiding this comment.
Yes, I will close this PR and move to your branch.
I've done a rebase early on, but on a branch different from main, to get your kzg implementation when testing. I think that's why we might end up with this! Sorry for the trouble :)
This PR re-organizes the repo into two different workspaces:
folding-schemesandfolding-schemes-solidity.While the
folding-schemesworkspace holds initial code, thefolding-schemes-solidityone contains all relevant evm contracts for each of the verifiers. Three different contracts are included, along with their respective templates. We provide adequate tests for each of those.