Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved Issue #3145 #3297

Conversation

Harshit-7373
Copy link

Wrong language is shown in the console. #3145

github- Harshit-7373

Fixes #issue-number

Changes:

  1. You Have to change the language to "English" in the top right corner of the p5.js web editor .
  2. If the issue still persists , Go to the Google Chrome settings and Change the language to "English" completely.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Wrong language is shown in the console. processing#3145

github- Harshit-7373
@raclim
Copy link
Collaborator

raclim commented Dec 5, 2024

Thanks for creating this suggestion!

Ideally, pull requests should mostly be focused on making changes to the code to resolve issues rather than through text/images. These types of suggested fixes should be formatted as responses to the issues rather than as pull requests (which I see you've already done!). Your other pull request (#3293) is similarly formatted to this as well.

I'm going to close this one and the other one for now, but please feel free to comment on the thread for the other issue as well with your suggested fix!

@raclim raclim closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants