[syedbarkath980]

Issue:

Fixes #4344

Description

This PR fixes an issue where the defaultHTML function reference was assigned directly to the content property of the default index.html file instead of invoking the function to retrieve its returned HTML string.

As a result, examples displayed the raw JavaScript function source in the preview instead of rendering the expected HTML page and p5.js sketch.

The fix invokes defaultHTML() so that the generated HTML content is correctly stored in the project.

Before

improper.defaultHTML.function.call.Before.fix.mp4

After

improper.defaultHTML.function.call.After.fix.mp4

The above video demonstrate that sketch correctly renders the HTML page.

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• has no typecheck errors (npm run typecheck)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123
• meets the standards outlined in the accessibility guidelines

[clairep94]

Hi @syedbarkath980 this looks good, thanks for fixing so quickly!

Would you be able to update your demo to just check that /all/ the example sketches work as expected?
Reasoning is that they're quite old and are on p5 v1.11.13, and the editor now is on v2 as default.

If any of them don't work, maybe we should update to defaultHTML({ version: '1.11.13' }) as a patch. Or simply delete any outdated p5v1 example sketches to reduce maintainence?

Thoughts @doradocodes @ksen0?

[syedbarkath980]

@clairep94 i tried to run other "Example Sketches" as well but getting this error:

temperrors.mp4

i applied your suggested patch: defaultHTML({ version: '1.11.13' }) and regenerate the sketches and tested once again and with this patch every sketch was working fine except only one:

temperrors.fix.after.patch.mp4

In the previous "After Fix" video i did not shown the sketches which was giving errors because i thought that was unrelated to PR.

What should i do now? should i commit with the suggested patch version?

[clairep94]

Thanks @syedbarkath980 again for the quick response!

I think let's update the PR to do the defaultHTML({ version: '1.11.13' }) patch fix

Could you please also create the following new issues?

• Add column to display p5 version to sketch list & add filter/sorting by p5 version to sketch list
• Update Example Sketches to include p5 v2 examples
  • Note that when users click on a sketch, its associated version should be used, rather than a hardcoded version number

[syedbarkath980]

Hi @clairep94 i have updated the PR to do the defaultHTML({ version: '1.11.13' }) patch fix.

For the issues you asked me to create:

• Add column to display p5 version to sketch list & add filter/sorting by p5 version to sketch list
• Update Example Sketches to include p5 v2 examples

There is already 2 issues exists for the same:
#4106
#4313

Should i still go ahead and create these issues?