Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e tests to pull busybox from quay.io #692

Closed

Conversation

dgrove-oss
Copy link

@dgrove-oss dgrove-oss commented Nov 15, 2023

Issue link

#661

What changes have been made

busybox:latest pulled from quay.io instead of k8s.gcr.io (to get arm64 image)

Verification steps

Re-run e2e-test-kind

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • [ x ] Unit tests
    • [ x ] Manual tests
    • Testing is not required for this change

Use quay.io/project-codeflare/busybox instead of k8s.icr.io/busybox
to ensure we get proper multiarch images.
Copy link
Contributor

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested e2e tests locally, pulls the image perfectly.

/lgtm /approve

Copy link

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ChristianZaccaria, KPostOffice
Once this PR has been reviewed and has the lgtm label, please assign metalcycling for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrove-oss
Copy link
Author

Closing as irrelevant. This repo is not being maintained.

@dgrove-oss dgrove-oss closed this Apr 16, 2024
@dgrove-oss dgrove-oss deleted the multiarch-busybox branch April 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants