spec: also set required context on PRs #30
Conversation
|
@cgwalters, WDYT? I could make it another setting I suppose so that repos that don't use homu don't have another status. (I don't mind them, though I know you had some reservations). This also paves the way towards only having the |
jlebon
force-pushed
the
pr/required-on-prs
branch
from
dc92027 to
7ce8999
Compare
|
Rebased. I've been thinking about this today. I think this is worth it just for the savings in test resources alone, esp. given that we have a lot of hungry testsuites nowadays. Though being able to use it in branch protection settings is really nice too. |
|
Those repos would just get the new status if they used Anyways seems sane to me! |
For the same reasons the 'required' context is useful for branches, it can also be useful for PRs: it allows repo admins to set a single status as required in the branch protection settings rather than multiple, possibly changing, statuses. This also specifically helps with status-based exemptions in Homu: by having the required context set on the PR, Homu will be able to determine whether it can safely skip re-testing the code on the auto branch.
jlebon
force-pushed
the
pr/required-on-prs
branch
from
7ce8999 to
78b573b
Compare
|
Rebased! ⬆️
Yes, that's correct!
Yeah, part of #62 is definitely to make these kinds of integrations smoother. Though it's easy enough to support in the meantime. |
|
LGTM |
|
@rh-atomic-bot r=cgwalters 78b573b |
1 similar comment
|
@rh-atomic-bot r=cgwalters 78b573b |
|
🙀 |
|
☀️ Test successful - status-papr |
For the same reasons the 'required' context is useful for branches, it
can also be useful for PRs: it allows repo admins to set a single status
as required in the branch protection settings rather than multiple,
possibly changing, statuses.
This also specifically helps with status-based exemptions in Homu: by
having the required context set on the PR, Homu will be able to
determine whether it can safely skip re-testing the code on the auto
branch.