Repository navigation
Take the version from the release tag alone - #12
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release's version is now declared once, by its tag. There is no
furyVersionto bump before tagging, so a tag can no longer disagree withbuild.milland fail the release.settings.versiongivesFURY_RELEASE_VERSIONwhen a release or snapshot sets it. Otherwise it gives the patch after the latest release tag reachable from HEAD: 0.7.1 after 0.7.0, which sorts after that release and before whichever follows. Where no release tag is reachable, as in CI's shallow checkout, it gives0.0.1.publishVersionis that version, andbuildVersionis that version plus the tree hash outside a release.fury-coreatcore.publishVersion(). In a release that is the tag's version, which is the coordinate Burdock must externalize against.make snapshottakes its base from./mill show fury.core.publishVersion, so a snapshot after 0.7.0 is0.7.1-<hex>.release.shalready skips its pin check whenbuild.milldeclares no version.A development build's
publishLocalalso no longer installs jars under a released version, where they could shadow the real release in~/.ivy2/local.Verified locally:
./mill show fury.core.publishVersiongave the patch after the latest local tag.FURY_RELEASE_VERSION=9.8.7,publishVersionand the launcher'smvnDepsboth gave 9.8.7.buildVersiongave the next version with the tree hash.🤖 Generated with Claude Code