Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate-france.py #708

Closed
wants to merge 2 commits into from
Closed

Conversation

Altonss
Copy link
Collaborator

@Altonss Altonss commented Dec 16, 2024

A file name changed...

@jbruechert
Copy link
Collaborator

There is also this issue:

Warning: Found duplicate source name: fr_reseau-urbain-la-navette-commune-de-gaillac--gtfs-gaillac.zip

@Altonss
Copy link
Collaborator Author

Altonss commented Dec 16, 2024

There is also this issue:

Warning: Found duplicate source name: fr_reseau-urbain-la-navette-commune-de-gaillac--gtfs-gaillac.zip

Well looks like we can't trust data producers to select unique titles to their files and not uploading duplicates..., it's already the second dataset doing this 🤷 :/ Initially I wanted to avoid using the id's as identifiers because it'd make fr.json not well understandable, but with all this mess maybe the best naming scheme could be something like : name = slug--id ? The resource ids should be unique and somewhat stable ^^ What do you think?

And to avoid association errors with the GTFS-RT at regeneration, simply add a check to see if a GTFS feed has this name and isn't skipped? 🤔

@jbruechert
Copy link
Collaborator

I think using the id is fine

@Altonss
Copy link
Collaborator Author

Altonss commented Dec 16, 2024

I think using the id is fine

I'll try that, thanks :)

@Altonss Altonss closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants