Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added repo_config json file #3298

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Added repo_config json file #3298

merged 1 commit into from
Nov 3, 2023

Conversation

ipanova
Copy link
Member

@ipanova ipanova commented Oct 24, 2023

closes #2902
closes #2903

@ipanova ipanova marked this pull request as draft October 24, 2023 11:13
@ipanova ipanova force-pushed the dnf-config branch 8 times, most recently from c5487b1 to 2d77351 Compare October 24, 2023 13:41
@ipanova ipanova requested review from ggainey and dralley and removed request for ggainey October 24, 2023 14:33
@ipanova ipanova marked this pull request as ready for review October 24, 2023 14:33
@dralley dralley mentioned this pull request Oct 24, 2023
Closed
dralley
dralley requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ipanova ipanova force-pushed the dnf-config branch 6 times, most recently from ae3a088 to 52b4422 Compare October 30, 2023 14:01
dralley
dralley reviewed Oct 30, 2023
View reviewed changes
CHANGES/2903.feature Outdated Show resolved Hide resolved
dralley
dralley reviewed Oct 30, 2023
View reviewed changes
pulp_rpm/app/viewsets/repository.py
)
gpgcheck = serializer.validated_data.get("gpgcheck")
repo_gpgcheck = serializer.validated_data.get("repo_gpgcheck")
gpgcheck_options = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. But I'm a little confused if it really needs to happen in both places?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one is for repo and second is for publication

@ipanova ipanova force-pushed the dnf-config branch 2 times, most recently from 5e6a8c2 to 3915d96 Compare October 31, 2023 10:52
ggainey
ggainey requested changes Nov 1, 2023
View reviewed changes
CHANGES/2903.deprecation Outdated Show resolved Hide resolved
pulp_rpm/app/serializers/repository.py Outdated Show resolved Hide resolved
pulp_rpm/app/migrations/0054_remove_gpg_fields.py Show resolved Hide resolved
@ipanova ipanova requested review from ggainey and dralley November 2, 2023 17:31
@ggainey ggainey merged commit 8fda3c8 into pulp:main Nov 3, 2023
15 checks passed
@jlsherrill jlsherrill mentioned this pull request Dec 8, 2023
Closed
pedro-psb added a commit to pedro-psb/pulp_rpm that referenced this pull request Jan 2, 2024
@pedro-psb
Fix server error when using gpgcheck/repo_gpgcheck
a652357 
pulp#3298 moved gpg options to a single
field called "repo_config", but the deprecated "gpgcheck" and "repo_gpgcheck"
were still being passed to the models, which caused a TypeError when trying
to use them.

closes pulp#3357
pedro-psb added a commit to pedro-psb/pulp_rpm that referenced this pull request Jan 2, 2024
@pedro-psb
Fix server error when using gpgcheck/repo_gpgcheck
04b238d 
pulp#3298 moved gpg options to a single
field called "repo_config", but the deprecated "gpgcheck" and "repo_gpgcheck"
were still being passed to the models, which caused a TypeError when trying
to use them.

closes pulp#3357
@pedro-psb pedro-psb mentioned this pull request Jan 2, 2024
Merged
pedro-psb added a commit to pedro-psb/pulp_rpm that referenced this pull request Jan 3, 2024
@pedro-psb
Fix server error when using gpgcheck/repo_gpgcheck
9779aa9 
pulp#3298 moved gpg options to a single
field called "repo_config", but the deprecated "gpgcheck" and "repo_gpgcheck"
were still being passed to the models, which caused a TypeError when trying
to use them.

closes pulp#3357
pedro-psb added a commit to pedro-psb/pulp_rpm that referenced this pull request Jan 4, 2024
@pedro-psb
Fix server error when using gpgcheck/repo_gpgcheck
afc0fbc 
pulp#3298 moved gpg options to a single
field called "repo_config", but the deprecated "gpgcheck" and "repo_gpgcheck"
were still being passed to the models, which caused a TypeError when trying
to use them.

closes pulp#3357
dralley pushed a commit that referenced this pull request Jan 4, 2024
@pedro-psb @dralley
Fix server error when using gpgcheck/repo_gpgcheck
149bb14 
#3298 moved gpg options to a single
field called "repo_config", but the deprecated "gpgcheck" and "repo_gpgcheck"
were still being passed to the models, which caused a TypeError when trying
to use them.

closes #3357
patchback bot pushed a commit that referenced this pull request Jan 4, 2024
@pedro-psb @patchback
Fix server error when using gpgcheck/repo_gpgcheck
677e1ec 
#3298 moved gpg options to a single
field called "repo_config", but the deprecated "gpgcheck" and "repo_gpgcheck"
were still being passed to the models, which caused a TypeError when trying
to use them.

closes #3357

(cherry picked from commit 149bb14)
@patchback patchback bot mentioned this pull request Jan 4, 2024
Merged
dralley pushed a commit that referenced this pull request Jan 5, 2024
@pedro-psb @dralley
Fix server error when using gpgcheck/repo_gpgcheck
1a290a2 
#3298 moved gpg options to a single
field called "repo_config", but the deprecated "gpgcheck" and "repo_gpgcheck"
were still being passed to the models, which caused a TypeError when trying
to use them.

closes #3357

(cherry picked from commit 149bb14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggainey ggainey ggainey approved these changes

@dralley dralley dralley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to set gpgKey value for repository Support repository option skip_if_unavailable
3 participants
@ipanova @dralley @ggainey