(bug) - Add lib dir to built modules #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the lib dir would be missing from built modules. This meant any types/providers defined in lib/ were not included in the modules, resulting in broken installs.
danadoherty639
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, the lib dir would be missing from built modules. This meant any types/providers defined in lib/ were not included in the modules, resulting in broken installs.
Provide a detailed description of all the changes present in this pull request.
Additional Context
Any module with custom type CI would fail as type was not known to puppet.
https://github.com/puppetlabs/puppetlabs-firewall/actions/runs/10913207968/job/30299482494#step:9:27
https://github.com/puppetlabs/puppetlabs-dsc_lite/actions/runs/10912992683
Related Issues (if any)
Mention any related issues or pull requests.
Checklist