(PE-39352) Add version to get peadm config #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpartlow
commented
Nov 22, 2024
|
Hmm, the github actions suite seems pretty unhappy atm. |
mcdonaldseanp
approved these changes
Nov 22, 2024
|
Well, Sean had run into the patron gem building error in enterprise_tasks, and I added his patch to the actions in c7651f3, but while that does allow bundler to build, the actions are now failing in the provision step. |
bastelfreak
reviewed
Nov 22, 2024
jpartlow
force-pushed
the
pe-39352-add-version-to-get-peadm-config
branch
from
c7651f3 to
9345eab
Compare
|
Alright, I think this is ready to go now. |
mcdonaldseanp
approved these changes
Dec 4, 2024
The 'PE HA Replica' node group is present in all PE installations, installed with or without PEADM. Switched this to check for the 'PE Primary A' node group that a PEADM installation specifically creates.
Adds a lookup of the pe_build file to provide the PE version in the hash returned by the get_peadm_config task. We will use this in add_database and backup/restore plans as a version gate for handling the newer host_action_collector database that is only present in PE 2023.7+, for example.
jpartlow
force-pushed
the
pe-39352-add-version-to-get-peadm-config
branch
from
9345eab to
7e77c21
Compare
jhbuchanan45
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a lookup of the pe_build file to provide the PE version in the hash
returned by the get_peadm_config task.
We will use this in add_database and backup/restore plans as a version
gate for handling the newer host_action_collector database that is only
present in PE 2023.7+, for example.
Checklist
Changes include test coverage?
Debated this; get_peadm_config task doesn't currently have a spec. I could certainly add one, if we'd like to expand the coverage there, but it's quite a bit more code than the pe_version addition :)
Have you updated the documentation?