getDeviceInterests doesn't support pagination as per API docs
#115
Labels
Comments
This was referenced Oct 26, 2022
Merged
|
Hey @Harsh-br0 , thanks for your submission! Could I have your email address so we can send you some swag? |
Sure @britneycodes , Here it is [email protected] Edit:I haven't received any email yet... |
sonologico
added a commit
that referenced
this issue
Dec 3, 2022
As per docs, getDeviceInterests must accept limit and cursor args to be passed with query parameters in the API. Currently, API returns 100 results since limit implies with 100 as default value in API, so i first redesigned the endpoint caller function here to accept query params as object in params arg and reworked the getDeviceInterests method here to return value as Object that includes cursor field from API response and add limit and cursor to method parameters. Also I've added a test for params arg in do-request.test.js Notable Changes getDeviceInterests now returns Object instead of an Array. Internal doRequest function can have params arg in Object to represent query params in URL Co-authored-by: Raphael Sousa Santos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up of #80
As per this issue-comment
The text was updated successfully, but these errors were encountered: