Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get interests does not implement pagination #80

Open
jonathanlloyd opened this issue Feb 16, 2021 · 5 comments
Open

Get interests does not implement pagination #80

jonathanlloyd opened this issue Feb 16, 2021 · 5 comments
Assignees
Labels
bug Something isn't working hacktoberfest

Comments

@jonathanlloyd
Copy link
Contributor

jonathanlloyd commented Feb 16, 2021

Bug Report

The getDeviceInterests method does not implement the pagination protocol used by the handler

Reproduction Steps

Call getDeviceInterests on a device that has > 100 subscriptions

Expected Result

All device interests should be returned

Actual Result

Only the first 100 interests (the first page) will be returned

@jonathanlloyd jonathanlloyd added the bug Something isn't working label Feb 16, 2021
@akarsh-jain-790
Copy link

@britneycodes I would love to work on this.

@britneycodes
Copy link

Hey @akarsh-jain-790, it's all yours!

@Harsh-br0
Copy link
Contributor

Is it still under work?
I have already done this locally so can you assign this to me if it's inactive @britneycodes

@britneycodes
Copy link

Hey @Harsh-br0, could you create an issue with your solution and we'll be able to accept your solution for hacktoberfest!

@Harsh-br0
Copy link
Contributor

Hey @Harsh-br0, could you create an issue with your solution and we'll be able to accept your solution for hacktoberfest!

Hi, so I've opened #115 and corresponding pull request #116 to it
@britneycodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants