Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dependencies and Modernise Codebase #153

Merged
merged 16 commits into from
Jan 3, 2025
Merged

Update Dependencies and Modernise Codebase #153

merged 16 commits into from
Jan 3, 2025

Conversation

hnhv
Copy link
Member

@hnhv hnhv commented Jan 3, 2025

This pull request introduces several updates aimed at addressing outdated and vulnerable dependencies, modernising the codebase, and improving maintainability.

Key changes:

  • Dependency upgrades:
    • Updated Node.js version in GitHub Actions workflow from 14 to 22.
    • Upgraded various npm dependencies and their configurations to the latest secure versions, including:
      • eslint and related plugins,
      • jest and its configs,
      • Babel and Rollup plugins.
    • Patched vulnerable packages (braces, lodash, semver) through overrides in package.json. This serves as a temporary measure while we continue to modernise the library further.
  • ESLint Configuration
    • Migrated to the new eslint.config.mjs standard
  • Test Enhancements
    • Updated timeout management to ensure compatibility with modern Jest.
    • Refactored some tests to use async/await for better readability and maintainability (this was mostly just for my own debugging).

hnhv added 15 commits December 31, 2024 12:33
@hnhv
Bump selenium-webdriver from 4.0.0-alpha.3 to 4.7.1
e92948c
@hnhv
run npm audit fix to resolve vulnerabilities
2510d98
@hnhv
Upgrade to ESLint 9, Migrate ESLint configuration and update dependen…
bb01d07 
…cies
@hnhv
Update Babel and related dependencies to latest versions
1c017c4
@hnhv
Migrate Rollup configuration and update dependencies
68d6fc3 
- Replaced deprecated Rollup plugins with maintained counterparts:
  - `rollup-plugin-babel` -> `@rollup/plugin-babel`
  - `rollup-plugin-commonjs` -> `@rollup/plugin-commonjs`
  - `rollup-plugin-node-resolve` ->  `@rollup/plugin-node-resolve`
@hnhv
Update prettier and Apply Prettier 3.x formatting changes
a637bfd
@hnhv
Removed vulnerable versions of (2.x) and replaced with using npm over…
81dbb09 
…rides.
@hnhv
Update Jest and other dependencies. Increase test-specific timeouts
93063e4
@hnhv
resolve vulnerabilities by overriding semver and lodash versions
eeded90
@hnhv
bump node version for CI
3bf500a
@hnhv
bump node version for CI again
6209a17
@hnhv
refactored end-to-end-tests/sdk-set-user-id.test.js by replacing prom…
af5b76e 
…ise chain in beforeAll and beforeEach with async/awaits, log google-chrome and chromedriver versions
@hnhv
increase timeout for e2e sdk-set-user-id test
a358b65
@hnhv
Migrate Rollup Json plugin to new version
7a784ed
@hnhv
Remove commented out code
c09730d
@hnhv hnhv self-assigned this Jan 3, 2025
@hnhv hnhv requested review from aonemd and evgeniibreikin January 3, 2025 09:44
aonemd
aonemd reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@aonemd aonemd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work reviving the library 🔥

end-to-end-tests/sdk-start.test.js Show resolved Hide resolved
@hnhv hnhv merged commit e6a70d7 into master Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeniibreikin evgeniibreikin evgeniibreikin approved these changes

@aonemd aonemd aonemd approved these changes

Assignees

@hnhv hnhv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hnhv @aonemd @evgeniibreikin