Repository navigation
Conversation
read_epw labels each EPW record with the start of its hour (EPW hour 1 becomes 00:00), while read_tmy3 labels each record with the end of its hour, so the same data read from an EPW and a TMY3 file are one hour apart. Say so in a warning, as read_tmy3 does, and show how to label the records with the time given in the EPW file. See pvlib#1156. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hey @cdeil! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content Finally, be sure the PR description includes the PR |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes.read_epwlabels each EPW record with the start of its hour (EPW hour 1 becomes 00:00, fromhour - 1in_parse_epw), but the docstring only says "Days run from 0-23h". EPW irradiance and illuminance are totals over the hour ending at the time in the file, while temperature, humidity and pressure are values at that time, andread_tmy3labels its records with the end of the hour and warns about it. So the same data read withread_epwandread_tmy3are one hour apart, which is what #1156 reports.This PR documents the convention with a warning like the one in
read_tmy3, including the one-line shift that labels the records with the time given in the file. Changing the index itself would break existing users; if you would rather do that (perhaps behind a parameter), I'm happy to follow up with a PR. I ran into this while aligning EPW weather for a building simulation side project.Checked:
read_epwontests/data/NLD_Amsterdam062400_IWEC.epwwithcoerce_year=2001gives 2001-01-01 00:00 for EPW hour 1 and 2001-12-31 23:00 for the last record;tests/iotools/test_epw.pypasses; flake8 is clean. I'll add the:pull:reference to the what's-new entry once this has a number.Prepared with AI assistance (Claude); I reviewed it.