Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize make_matrices #339

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

qbarthelemy
Copy link
Member

This PR:

  • adds kinds = "sym" and "herm" in make_matrices to respectively generate symmetric and Hermitian matrices;
  • adds new parameters eigvecs_mean and eigvecs_std to make_matrices,
    controlling the mean and standard deviation of the normal distribution used to draw eigen vectors;
  • deprecates generate_random_spd_matrix, because redundant with make_matrices;
  • adds missing tests for make_outliers;
  • improves documentation for dataset module;
  • completes tests for rjd and uwedge, supporting symmetric matrices.

@agramfort agramfort merged commit 0a94651 into pyRiemann:master Jan 9, 2025
10 checks passed
@qbarthelemy qbarthelemy deleted the make_matrices branch January 9, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants