Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proxy that requires DigestAuth #233

Closed
wants to merge 6 commits into from
Closed

Support proxy that requires DigestAuth #233

wants to merge 6 commits into from

Conversation

raffaem
Copy link
Contributor

@raffaem raffaem commented Dec 30, 2021

This is a first attempt to support proxies that requires DigestAuth rather than BasicAuth.

It is not perfect but it's the only working solution I could find that supports connection to HTTPS websites (the other solutions don't support connection to HTTP websites)

@Michael-E-Rose Michael-E-Rose force-pushed the master branch 2 times, most recently from 039774c to a8978b3 Compare January 1, 2022 15:13
@raffaem raffaem closed this Jan 18, 2022
@Michael-E-Rose
Copy link
Contributor

Are you going to create a new clean PR for the DigestAuth thingy?

@raffaem
Copy link
Contributor Author

raffaem commented Jan 29, 2022

Are you going to create a new clean PR for the DigestAuth thingy?

It was based on some code I found on StackOverflow, with heavy monkey patching of requests and httplib that I don't fully understands.

I raised an issue on toolbelt, without answer, and one on requests, which is not going to implement it in the near future.

I raised a discussion on httpx which eventually escalated into an issue to implement it.

Maybe once it is implemented in httpx, we can re-base pybliometrics on httpx and implement DigestAuth for proxies without monkey patching.

Or otherwise I'll re-submit the PR, it worked but I can't figure quite out all the monkey patching.

@Michael-E-Rose
Copy link
Contributor

Wow, that's a lot of issues that you raised there!

I'm curious what comes out of this. If none of this is too complex nor breaks the current interface, then we should seriously consider switching to DigestAuth.

@raffaem
Copy link
Contributor Author

raffaem commented Feb 1, 2022

Wow, that's a lot of issues that you raised there!

I'm curious what comes out of this. If none of this is too complex nor breaks the current interface, then we should seriously consider switching to DigestAuth.

If you wish you can check the commit of my fork which implements DigestAuth for proxies.

Otherwise just wait for httpx to implement it?

If I'm understanding correctly, all pybliometrics internet communication happens through get_content.py.

Then it should not be too difficult to switch to httpx if one wishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants