Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering
Model.get_attributes()raisesAttributeErrorwhen a model contains aMapAttribute. Map descriptors deliberately have noattribute_values, but the inherited representation tries to read it.Use the ordinary attribute representation for map descriptors and preserve the existing field representation for map values. Tests cover raw and typed descriptors, rendering the attribute dictionary, and empty and populated map values.
Fixes #1259.
Validated on macOS:
pytest tests/ -k "not ddblocal": 393 passed, 21 deselected on Python 3.8.20 and 3.12.13.mypy .on Python 3.8.20, matching the typing CI environment: no issues in 62 source files.DynamoDB Local integration tests and live AWS operations were not run.