Skip to content

Commit

Permalink
Merge pull request #6300 from pradyunsg/docs/dev-docs-flake8-revision
Browse files Browse the repository at this point in the history
Remove note about flake8 noqa comments
  • Loading branch information
pradyunsg authored Feb 26, 2019
2 parents 821247d + 45d16ac commit c2661ef
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions docs/html/development/getting-started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@ The above commands run the linters on Python 2 followed by Python 3.
.. note::

Do not silence errors from flake8 with ``# noqa`` comments or otherwise.
The only exception to this is silencing unused-import errors for imports
related to static type checking as currently `flake8 does not understand
PEP 484 type-comments`_.

Running mypy
------------
Expand Down Expand Up @@ -115,6 +112,5 @@ To build it locally, run:
The built documentation can be found in the ``docs/build`` folder.

.. _`open an issue`: https://github.com/pypa/pip/issues/new?title=Trouble+with+pip+development+environment
.. _`flake8 does not understand PEP 484 type-comments`: https://gitlab.com/pycqa/flake8/issues/118
.. _`PEP 484 type-comments`: https://www.python.org/dev/peps/pep-0484/#suggested-syntax-for-python-2-7-and-straddling-code
.. _`rich CLI`: https://docs.pytest.org/en/latest/usage.html#specifying-tests-selecting-tests

0 comments on commit c2661ef

Please sign in to comment.