-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "only-version" version scheme #1005
Conversation
for more information, see https://pre-commit.ci
@pytest.mark.parametrize( | ||
"version", | ||
[ | ||
"1.dev0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ripped from https://peps.python.org/pep-0440/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the name should be only-tag and the docs need a warning that this means version is no longer pseudo unique per commit
Still adding a blanket approval
I'll try to get this in this morning or by the weekend
…tools_scm into jcannon/fix1002
for more information, see https://pre-commit.ci
…tools_scm into jcannon/fix1002
Done and done. |
thanks, would you like to see this squashed or should i merge as is? |
Oh I'm definitely camp squash-merge. "Rename" isn't much of an inspiring commit message 😂 |
@RonnyPfannschmidt when might there be a new version of Thanks! 🙏 |
I'll try to merge the clean up mr soon and releas this week |
Here's a bump on getting that release up and going as I'd like to use |
Fixes #1002 by adding a "only-version" version scheme.