Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding prettier tool #1060

Closed
wants to merge 3 commits into from
Closed

Adding prettier tool #1060

wants to merge 3 commits into from

Conversation

jamesbraza
Copy link
Contributor

I noticed the docs had extra whitespace. This PR add prettier and end-of-file-fixer to pre-commit for standardized spacing

RonnyPfannschmidt
RonnyPfannschmidt requested changes Jul 28, 2024
View reviewed changes
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im happy to add some fixes, but i am well aware why prettier is no longer under pre-commit and i will not add that tool unless the pre-commit maintainers are convinced it wont mess up everything again

i was at the end of said breakages multiple times myself and consider it scorched earth for now

@jamesbraza
Copy link
Contributor Author

Fwiw this PR uses https://github.com/rbubley/mirrors-prettier (as opposed to the archived https://github.com/pre-commit/mirrors-prettier). Regardless, I reverted the addition of prettier to .pre-commit-config.yaml.

Are you okay with the changes prettier makes? Also, feel free to just close this PR if you're not interested at all, I am not attached to it.

@jamesbraza
Copy link
Contributor Author

Alright I just rebased this atop main 🤓 . Note there is no mirrors-prettier here in this PR, just the changes made by the tool, as if it was a ghost 👻

RonnyPfannschmidt
RonnyPfannschmidt reviewed Oct 1, 2024
View reviewed changes
docs/extending.md
options:
show_root_heading: yes
heading_level: 4
options:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its broken

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dang, too bad. I made prettier/prettier#16713

I will close this PR as this seems to be a critical bug

@jamesbraza jamesbraza closed this Oct 1, 2024
@jamesbraza jamesbraza deleted the prettier branch October 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @RonnyPfannschmidt