Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fischer-Tropsch efficiency in capital cost calculation #240

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

energyLS
Copy link
Collaborator

@energyLS energyLS commented Oct 31, 2023

Changes proposed in this Pull Request

Fix capital_cost of Fischer-Tropsch. Since the investment parameter of technology data relates to EUR/MW_FT the efficiency is used to convert from EUR/MW_FT/a to EUR/MW_H2/a (https://github.com/PyPSA/technology-data/blob/8bb05d94ac603c463683b5ae12acf438fb962b4f/outputs/costs_2030.csv#L97).

This is is in line with PyPSA-Eur
https://github.com/PyPSA/pypsa-eur/blob/f35ecbe4a01f220210c3a295ca93d805f5633824/scripts/prepare_sector_network.py#L2718C9-L2719C68

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@energyLS energyLS changed the title fix: add ft efficiency in capital cost calculation Add Fischer-Tropsch efficiency in capital cost calculation Oct 31, 2023
@energyLS
Copy link
Collaborator Author

energyLS commented Nov 2, 2023

Mac CI successful, please review and merge @hazemakhalek :)

@energyLS energyLS requested a review from hazemakhalek November 2, 2023 15:24
@hazemakhalek hazemakhalek merged commit 71134d2 into main Nov 2, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants