Skip to content

Fix --failed-first crash on collection errors and nested classes - #109

Merged
nicoddemus merged 1 commit into
mainfrom
claude/project-thread-8u5lt1
Nov 19, 2026
Merged

nicoddemus merged 1 commit into
mainfrom
claude/project-thread-8u5lt1

Conversation

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

Requested by Ronny · project thread

🤖 Written by Claude Opus 5.5 via Claude Code for the pytest-random-order maintainers; I prompted it, it did the work, I read it.

--failed-first raised NotImplementedError whenever cache/lastfailed held a key that isn't 2 or 3 :: parts, e.g. a module with a collection error or a test in a nested class. The list that raised was never used, so this drops it. The new test covers both cases and fails on main.

Fixes #41, fixes #53. Supersedes #107.


Generated by Claude Code

The unused last_failed list raised NotImplementedError for cache keys
such as a module with a collection error or a test in a nested class.
Drop it; bucketing already uses the raw nodeids.

Fixes #41, fixes #53.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014GZsRGzNKfTWbvu7XjSc6F
@nicoddemus

Copy link
Copy Markdown
Member

Thanks!

@nicoddemus
nicoddemus merged commit b243710 into main Nov 19, 2026
12 checks passed
@nicoddemus
nicoddemus deleted the claude/project-thread-8u5lt1 branch November 19, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in --failed-first? process_failed_first_last_failed → NotImplementedError

3 participants