Repository navigation
Fix --failed-first crash on collection errors and nested classes - #109
Merged
Merged
Conversation
The unused last_failed list raised NotImplementedError for cache keys such as a module with a collection error or a test in a nested class. Drop it; bucketing already uses the raw nodeids. Fixes #41, fixes #53. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014GZsRGzNKfTWbvu7XjSc6F
nicoddemus
approved these changes
Nov 19, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ronny · project thread
🤖 Written by Claude Opus 5.5 via Claude Code for the pytest-random-order maintainers; I prompted it, it did the work, I read it.
--failed-firstraisedNotImplementedErrorwhenevercache/lastfailedheld a key that isn't 2 or 3::parts, e.g. a module with a collection error or a test in a nested class. The list that raised was never used, so this drops it. The new test covers both cases and fails on main.Fixes #41, fixes #53. Supersedes #107.
Generated by Claude Code