Add new error and test

pyth-network · Jan 30, 2024 · 860b4a9 · 860b4a9
1 parent 4ba2740
commit 860b4a9
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/target_chains/solana/programs/pyth-solana-receiver/src/error.rs b/target_chains/solana/programs/pyth-solana-receiver/src/error.rs
@@ -37,6 +37,8 @@ pub enum ReceiverError {
     InvalidVaaVersion,
     #[msg("Guardian set version in the VAA doesn't match the guardian set passed")]
     GuardianSetMismatch,
+    #[msg("Guardian signature indices must be increasing")]
+    InvalidGuardianOrder,
     #[msg("Guardian index exceeds the number of guardians in the set")]
     InvalidGuardianIndex,
     #[msg("A VAA signature is invalid")]

diff --git a/target_chains/solana/programs/pyth-solana-receiver/src/lib.rs b/target_chains/solana/programs/pyth-solana-receiver/src/lib.rs
@@ -143,7 +143,7 @@ pub mod pyth_solana_receiver {
             // We do not allow for non-increasing guardian signature indices.
             let index = usize::from(sig.guardian_index());
             if let Some(last_index) = last_guardian_index {
-                require!(index > last_index, ReceiverError::InvalidGuardianIndex);
+                require!(index > last_index, ReceiverError::InvalidGuardianOrder);
             }
 
             // Does this guardian index exist in this guardian set?

diff --git a/target_chains/solana/programs/pyth-solana-receiver/tests/test_post_updates_atomic.rs b/target_chains/solana/programs/pyth-solana-receiver/tests/test_post_updates_atomic.rs
@@ -210,6 +210,30 @@ async fn test_post_updates_atomic_wrong_vaa() {
         into_transation_error(ReceiverError::GuardianSetMismatch)
     );
 
+    let mut vaa_copy: Vaa<&RawMessage> = serde_wormhole::from_slice(&vaa).unwrap();
+    vaa_copy.signatures[0] = vaa_copy.signatures[1];
+
+    assert_eq!(
+        program_simulator
+            .process_ix(
+                PostUpdatesAtomic::populate(
+                    poster.pubkey(),
+                    price_update_keypair.pubkey(),
+                    BRIDGE_ID,
+                    DEFAULT_GUARDIAN_SET_INDEX,
+                    serde_wormhole::to_vec(&vaa_copy).unwrap(),
+                    merkle_price_updates[0].clone(),
+                ),
+                &vec![&poster, &price_update_keypair],
+                None,
+            )
+            .await
+            .unwrap_err()
+            .unwrap(),
+        into_transation_error(ReceiverError::InvalidGuardianOrder)
+    );
+
+
     let mut vaa_copy: Vaa<&RawMessage> = serde_wormhole::from_slice(&vaa).unwrap();
     vaa_copy.signatures[0].index = 20;