[solana] Add wrong vaa tests #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
guibescos
commented
Jan 30, 2024
| @@ -2,16 +2,9 @@ use anchor_lang::prelude::*; | |||
|
|
|||
| #[error_code] | |||
| pub enum ReceiverError { | |||
There was a problem hiding this comment.
Reordered the errors to match the order of the tests
guibescos
commented
Jan 30, 2024
guibescos
commented
Jan 30, 2024
| @@ -143,7 +143,7 @@ pub mod pyth_solana_receiver { | |||
| // We do not allow for non-increasing guardian signature indices. | |||
| let index = usize::from(sig.guardian_index()); | |||
| if let Some(last_index) = last_guardian_index { | |||
| require!(index > last_index, ReceiverError::InvalidGuardianIndex); | |||
| require!(index > last_index, ReceiverError::InvalidGuardianOrder); | |||
There was a problem hiding this comment.
Changing this error because the same error code was used in another location
jayantk
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to exhaustively test all errors that the receiver can throw. This covers 12 errors of the 21.