Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Solana] More tests #1263

Merged
merged 21 commits into from
Jan 31, 2024
Merged

[Solana] More tests #1263

merged 21 commits into from
Jan 31, 2024

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Jan 30, 2024

After this PR we are covering all the possible ReceiverErrors in the tests

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 2:37pm
xc-admin-frontend ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 2:37pm

@guibescos guibescos marked this pull request as draft January 30, 2024 19:18
Base automatically changed from tests-wrong to main January 31, 2024 14:16
@guibescos guibescos marked this pull request as ready for review January 31, 2024 14:32
@@ -1304,7 +1310,7 @@ mod test {
for i in 0..10000 {
all_feeds.push(create_dummy_price_feed_message(i));
}
let msg = create_accumulator_message(&all_feeds, &all_feeds[100..110], false);
let msg = create_accumulator_message(&all_feeds, &all_feeds[100..110], false, false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arguments to this function changed

#[account(constraint =
payer.key() == config.target_governance_authority.ok_or(error!(ReceiverError::NonexistentGovernanceAuthorityTransferRequest))? @
ReceiverError::TargetGovernanceAuthorityMismatch
)]
pub payer: Signer<'info>,
#[account(seeds = [CONFIG_SEED.as_ref()], bump)]
#[account(mut, seeds = [CONFIG_SEED.as_ref()], bump)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol I had forgotten this

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@guibescos guibescos merged commit 1871ca1 into main Jan 31, 2024
7 checks passed
@guibescos guibescos deleted the solana/all-tests branch January 31, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants