feat(solana) : rust sdk #1303
Merged
feat(solana) : rust sdk #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
guibescos
force-pushed
the
solana/rust-sdk
branch
from
9cdab6a to
dea0835
Compare
guibescos
force-pushed
the
solana/rust-sdk
branch
from
dea0835 to
790209a
Compare
jayantk
approved these changes
Feb 21, 2024
target_chains/solana/pyth_solana_receiver_state/src/price_update.rs
Outdated
Show resolved
Hide resolved
|
One more comment: can you please document all of these SDK methods? Document them well -- this is code that people using Pyth may read, and good docs will answer all of their questions so they don't have to come ask us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some functions that people can use in their smart contract to consumer
PriceUpdateV1accounts.I need to add some more unit tests.