-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract transaction batching logic #1323
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
guibescos
changed the title
Solana/transaction logic
refactor: extract transaction batching logic
Feb 26, 2024
guibescos
commented
Feb 26, 2024
const allPythAccounts = await connection.getProgramAccounts( | ||
getPythProgramKeyForCluster(cluster) | ||
) | ||
const allPythAccounts = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by CI fix
guibescos
commented
Feb 26, 2024
@@ -32,4 +32,4 @@ jobs: | |||
- name: Run tests | |||
run: cargo-test-sbf | |||
- name: Run sdk tests | |||
run: cargo test --p pyth-solana-sdk | |||
run: cargo test --package pyth-solana-receiver-state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by ci fix
ali-bahjati
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use this batching logic in the pyth receiver sdk for Solana, so I'm moving it to a place where both
xc-admin-common
andpyth-receiver-solana
can use it