Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solana audit 2 #1333

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix: solana audit 2 #1333

merged 1 commit into from
Mar 1, 2024

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Feb 29, 2024

The big change here to review is the following. Previously during setup we had to pay rent of the treasury accounts otherwise when you send 1 lamport that doesn't cover the rent and it would fail. Now the first person to use a treasury account will pay the rent 0.0009 SOL. It makes it more ergonomic to deploy.

Other changes:

  • move minimum signatures check for consistency with the Wormhole codebase
  • try_deserialize_unchecked -> try_deserialize for the guardian check

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) Feb 29, 2024 8:23pm
xc-admin-frontend ⬜️ Ignored (Inspect) Feb 29, 2024 8:23pm

@guibescos guibescos merged commit e0f94ee into main Mar 1, 2024
5 checks passed
@guibescos guibescos deleted the audit-2/pay-treasury-rent-if-needed branch March 1, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants