feat: pyth pull-based push oracle #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
jayantk
reviewed
Mar 18, 2024
ali-bahjati
reviewed
Mar 19, 2024
guibescos
commented
Mar 29, 2024
| @@ -0,0 +1,28 @@ | |||
| [package] | |||
| name = "common-test-utils" | |||
There was a problem hiding this comment.
I extracted this here to be able to use it in pyth-solana-receiver and pyth-push-oracle at the same time
guibescos
changed the title
guibescos
changed the title
jayantk
approved these changes
Mar 29, 2024
|
|
||
| pub mod config; | ||
| pub mod error; | ||
| pub mod price_update; | ||
|
|
||
| declare_id!("rec5EKMGg6MxZYaMdyBfgwp4d5rB9T1VQH5pJv5LtFJ"); | ||
|
|
||
| pub const PYTH_PUSH_ORACLE_ID: Pubkey = pubkey!("F9SP6tBXw9Af7BYauo7Y2R5Es2mpv8FP5aNCXMihp6Za"); |
There was a problem hiding this comment.
This is confusing to me. You have a separate sdk.rs above for the push oracle which has some useful methods in it. It seems like there should either be one sdk for users of both push/pull, or two different ones. At the moment, it seems like a mix of both options (?)
There was a problem hiding this comment.
pyth-solana-receiver-sdkis for consuming price updatespyth_solana_receiver::sdkis for posting price updatespyth_push_oracle::sdkis for updating price feeds
There was a problem hiding this comment.
For this program id, I need to put it here because otherwise there are some circular dependencies that break the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a program that CPIs into the pyth solana receiver to post updates.
This program enforces that:
The meat is in target_chains/solana/programs/pyth-push-oracle/src/lib.rs