Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128397: Makes _delete attribute from TemporaryDirectory public #128643

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Prtm2110
Copy link

@Prtm2110 Prtm2110 commented Jan 8, 2025

Fixes: #128397
As mentioned it the issue this PR makes _delete attribute of TemporaryDirectory public, I will write tests and add change log accordingly.

Copy link

cpython-cla-bot bot commented Jan 8, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Prtm2110
Copy link
Author

Prtm2110 commented Jan 9, 2025

Hello, @graingert (I’m not sure if tagging you is appropriate here), but could you please provide a review of this?

Copy link
Contributor

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to write some test cases for mutating delete outside the constructor, and some docs changes.

Please also write a test case for what happens when the object is created with delete=True, changed to delete=False and then garbage collected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote _delete member of TemporaryDirectory to delete
2 participants