gh-128646: Implement GzipFile.readinto() functions #128647
Open
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
effigies
force-pushed
the
fix/gzipfile-readinto
branch
2 times, most recently
from
e94363a to
4eea459
Compare
effigies
force-pushed
the
fix/gzipfile-readinto
branch
from
4eea459 to
f272a9c
Compare
effigies
force-pushed
the
fix/gzipfile-readinto
branch
from
f272a9c to
db7f971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementations of
.readinto()and.readinto1()for GzipFile which pass the received buffer to the underlyingBufferedReader. Without this, the baseBufferedIOReaderimplementation is used, which simply calls.read()and copies into the target buffer.I don't know a good way to write a test to check memory usage, but see #128646 for a profile that demonstrates the effectiveness of the patch.