Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value #128653

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value #128653

wants to merge 2 commits into from
+17 −2

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jan 8, 2025 •
edited by bedevere-app bot
Loading

This fixes the crash by catching TypeError and ValueError in addition to KeyError. I'm not sure if this the best fix, but it's the least invasive one. Feedback welcome!

@bedevere-app bedevere-app bot mentioned this pull request Jan 8, 2025
Open
@tomasr8 tomasr8 added the needs backport to 3.13 bugs and security fixes label Jan 8, 2025
@tomasr8
Copy link
Member Author

tomasr8 commented Jan 9, 2025

I'll look into the test failure later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
awaiting review needs backport to 3.13 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomasr8