Repository navigation
gh-57945: Document exceptions not wrapped by urlopen() - #160830
Merged
Merged
Conversation
Exceptions raised while reading or parsing the HTTP response, such as http.client.HTTPException subclasses and OSError subclasses like TimeoutError, propagate from urlopen() without being wrapped in URLError. Document this, and that ValueError is raised for an invalid URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Documentation build overview
|
orsenthil
enabled auto-merge (squash)
October 28, 2026 15:52
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-160831 is a backport of this pull request to the 3.14 branch. |
|
GH-160832 is a backport of this pull request to the 3.15 branch. |
orsenthil
added a commit
that referenced
this pull request
Oct 28, 2026
) (#160831) gh-57945: Document exceptions not wrapped by urlopen() (GH-160830) Exceptions raised while reading or parsing the HTTP response, such as http.client.HTTPException subclasses and OSError subclasses like TimeoutError, propagate from urlopen() without being wrapped in URLError. Document this, and that ValueError is raised for an invalid URL. (cherry picked from commit 87f8c0d) Co-authored-by: Senthil Kumaran <senthil@python.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
orsenthil
added a commit
that referenced
this pull request
Oct 28, 2026
) (#160832) gh-57945: Document exceptions not wrapped by urlopen() (GH-160830) Exceptions raised while reading or parsing the HTTP response, such as http.client.HTTPException subclasses and OSError subclasses like TimeoutError, propagate from urlopen() without being wrapped in URLError. Document this, and that ValueError is raised for an invalid URL. (cherry picked from commit 87f8c0d) Co-authored-by: Senthil Kumaran <senthil@python.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
urlopen()documentation says only that it raisesURLErroron protocol errors. In practice, exceptions raised while reading or parsing the HTTP response come fromhttp.clientwithout being wrapped. These include:http.client.HTTPExceptionsubclasses such asBadStatusLine. These are notOSErrorsubclasses, so evenexcept OSErrormisses them.OSErrorsubclasses such asTimeoutError(the server doesn't respond within timeout) andRemoteDisconnected.ValueErroris also raised for a URL with no scheme.This happens because
AbstractHTTPHandler.do_open()wrapsOSErrorinURLErroronly aroundh.request(), not aroundh.getresponse().Earlier discussion on the issue (Antoine Pitrou, Martin Panter) and the related issues gh-53069, gh-66986 and gh-69819 settled on documenting this rather than adding more wrapping, which would break existing code. This PR changes only the documentation.
🤖 Generated with Claude Code
Helpful reproducer for this.