Skip to content

Arm backend: Add VGF mutable buffer aliasing - #23486

Open
xingguo01 wants to merge 3 commits into
pytorch:mainfrom
xingguo01:arm-backend-vgf-mutable-buffer-aliasing
Open

xingguo01 wants to merge 3 commits into
pytorch:mainfrom
xingguo01:arm-backend-vgf-mutable-buffer-aliasing

Conversation

@xingguo01

@xingguo01 xingguo01 commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Bind delegated mutable input and output resources to persistent VGF storage so static INT8 KV-cache updates survive across executions.

Record buffer pairs in the compile spec, validate supported cache buffers, and internalize their ExecuTorch I/O endpoints. Add coverage for compile-spec handling and MHA, GQA, and MQA cache layouts.

AI-assisted-by: Codex

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2026
@pytorch-bot

pytorch-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23486

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 897ea33 with merge base a519331 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Oct 6, 2026
@xingguo01 xingguo01 added release notes: arm Changes to the ARM backend delegate help wanted Extra attention is needed labels Oct 6, 2026
@xingguo01
xingguo01 force-pushed the arm-backend-vgf-mutable-buffer-aliasing branch 2 times, most recently from 592856a to 5c38b7f Compare October 12, 2026 14:53
@xingguo01
xingguo01 requested a review from rascani as a code owner October 12, 2026 14:53
@xingguo01
xingguo01 force-pushed the arm-backend-vgf-mutable-buffer-aliasing branch from 5c38b7f to 9c811b1 Compare October 15, 2026 10:36

@zingo zingo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is buck2 considered?

Bind delegated mutable input and output resources to persistent VGF
storage so static INT8 KV-cache updates survive across executions.

Record buffer pairs in the compile spec, validate supported cache
buffers, and internalize their ExecuTorch I/O endpoints. Add coverage
for compile-spec handling and MHA, GQA, and MQA cache layouts.

AI-assisted-by: Codex
Change-Id: Ia449334e737081878e05e49e84b787999ec156ad
Signed-off-by: Xingguo Li <xingguo.li@arm.com>
Exclude mutable KV endpoints before assigning zero-copy indices.
Extract the production mapping into a small helper so the test checks
the same path used by VGF setup. Keep remaining external input and
output indices stable, including absent input slots.

AI-assisted-by: Codex
Change-Id: I355066bbcbc1cf490c6522557bae6717bb0c8e1f
Signed-off-by: Xingguo Li <xingguo.li@arm.com>
Upstream requires vgflib 0.11.0, whose decoder exposes the
alias-group, sampler, SPIR-V, and descriptor-set APIs directly.
Remove compatibility branches for older libraries and their
single-use wrappers. This does not change the 0.11 path.

Validated by compiling vgf_backend against the 0.11.0 wheel and
running lintrunner on VGFSetup.cpp.

AI-assisted-by: Codex
Change-Id: Ifb92ae4f9a820134fd6c2d02e419fbc47676bfcf
Signed-off-by: Xingguo Li <xingguo.li@arm.com>
@xingguo01
xingguo01 force-pushed the arm-backend-vgf-mutable-buffer-aliasing branch from 7694a3d to 897ea33 Compare October 27, 2026 17:34
@xingguo01

Copy link
Copy Markdown
Collaborator Author

Addressed the buck2 test, Good catch, Zingo!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. help wanted Extra attention is needed module: arm Issues related to arm backend release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants