Repository navigation
Conversation
xingguo01
requested review from
JacobSzwejbka,
digantdesai,
larryliu0820 and
mergennachin
as code owners
October 6, 2026 14:03
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23486
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 897ea33 with merge base a519331 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
xingguo01
force-pushed
the
arm-backend-vgf-mutable-buffer-aliasing
branch
2 times, most recently
from
October 12, 2026 14:53
592856a to
5c38b7f
Compare
xingguo01
force-pushed
the
arm-backend-vgf-mutable-buffer-aliasing
branch
from
October 15, 2026 10:36
5c38b7f to
9c811b1
Compare
Bind delegated mutable input and output resources to persistent VGF storage so static INT8 KV-cache updates survive across executions. Record buffer pairs in the compile spec, validate supported cache buffers, and internalize their ExecuTorch I/O endpoints. Add coverage for compile-spec handling and MHA, GQA, and MQA cache layouts. AI-assisted-by: Codex Change-Id: Ia449334e737081878e05e49e84b787999ec156ad Signed-off-by: Xingguo Li <xingguo.li@arm.com>
Exclude mutable KV endpoints before assigning zero-copy indices. Extract the production mapping into a small helper so the test checks the same path used by VGF setup. Keep remaining external input and output indices stable, including absent input slots. AI-assisted-by: Codex Change-Id: I355066bbcbc1cf490c6522557bae6717bb0c8e1f Signed-off-by: Xingguo Li <xingguo.li@arm.com>
Upstream requires vgflib 0.11.0, whose decoder exposes the alias-group, sampler, SPIR-V, and descriptor-set APIs directly. Remove compatibility branches for older libraries and their single-use wrappers. This does not change the 0.11 path. Validated by compiling vgf_backend against the 0.11.0 wheel and running lintrunner on VGFSetup.cpp. AI-assisted-by: Codex Change-Id: Ifb92ae4f9a820134fd6c2d02e419fbc47676bfcf Signed-off-by: Xingguo Li <xingguo.li@arm.com>
xingguo01
force-pushed
the
arm-backend-vgf-mutable-buffer-aliasing
branch
from
October 27, 2026 17:34
7694a3d to
897ea33
Compare
Collaborator
Author
|
Addressed the buck2 test, Good catch, Zingo! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind delegated mutable input and output resources to persistent VGF storage so static INT8 KV-cache updates survive across executions.
Record buffer pairs in the compile spec, validate supported cache buffers, and internalize their ExecuTorch I/O endpoints. Add coverage for compile-spec handling and MHA, GQA, and MQA cache layouts.
AI-assisted-by: Codex
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani