Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scan] Test we don't recompile under debugging env flags #8555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tengyifei
Copy link
Collaborator

@tengyifei tengyifei commented Jan 10, 2025

When XLA_HLO_DEBUG=1 is set, the lowered HLO contains extra scope and line number information. When a function is scanned twice, the line numbers stay the same but the scopes will change. This tests that those differences don't cause the graph hash of the scan computation to change, so that we don't recompile on every scan call.

I'm able to add this test without any other code change thanks to the PRs #8550 and #8539 contributed by @rpsilva-aws

When XLA_HLO_DEBUG=1 is set, the lowered HLO contains extra scope and
line number information. When a function is scanned twice, the line
numbers stay the same but the scopes will change. This tests that those
differences don't cause the graph hash of the scan computation to
change, so that we don't recompile on every scan call.
@tengyifei tengyifei force-pushed the yifeit/scan-avoid-recompiles branch from d74c39c to 3b38a99 Compare January 11, 2025 01:17
@tengyifei tengyifei marked this pull request as ready for review January 11, 2025 01:17
@tengyifei tengyifei requested a review from lsy323 January 11, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants